refactor: Use constants from Twips where appropriate
#19061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-other
|
For some reason, reading |
Yeah... That's a bit confusing. I don't have a proposal of a better name though... :/ |
|
I had the same confusion and was thinking of bringing it up too. How about ONEPX? (Or ONE_PX if you prefer) |
danielhjacobs
approved these changes
Dec 26, 2024
|
I like |
Twips::ONE was ambiguous, because it suggested it's 1 twips, but it was 1 px instead.
Similarly to Twips::ONE_PX, this name change makes it obvious it's half a pixel, not half a twip.
evilpie
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a refactor that replaces
Twipsinstantiations with respective constants. Some instantiations in tests (byTwips::new) were left intact as they seem to focus on the pure numerical value instead of semantically the number of twips.