Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback regression in v0.8.5 #378

Closed
radar opened this issue Jul 10, 2017 · 0 comments
Closed

Fallback regression in v0.8.5 #378

radar opened this issue Jul 10, 2017 · 0 comments

Comments

@radar
Copy link
Collaborator

radar commented Jul 10, 2017

@rasoliveira helped me figure this one out. There's a regression between v0.8.4 and v0.8.5.

Here's a way to reproduce it:

Gemfile

source "https://rubygems.org"

gem "i18n", "0.8.4"
gem "pry"

repro.rb

require 'bundler'
Bundler.setup
require 'i18n'
require 'pry'

I18n.load_path = Dir["config/locales/*"]
I18n::Backend::Simple.include(I18n::Backend::Fallbacks)
I18n.fallbacks[:en] = [I18n.default_locale]
I18n.t('interpolate')

config/locales/en.yml

en:
  interpolate: "Interpolated %{value}"

Run bundle exec repro.rb, using 0.8.4 and it works, and 0.8.5 fails.
@radar radar closed this as completed in 09f8065 Jul 10, 2017
radar added a commit that referenced this issue Jul 11, 2017
@radar
Add regression test for #378
6ab51c7
radar added a commit that referenced this issue Oct 1, 2017
@radar
Merge branch 'master' into pr-51-thread-safety-fix
358249b 
* master: (45 commits)
  Add regression test for #378
  Bump to 0.8.6
  Add fallback_in_progress to RESERVED_KEYS list
  Bump to 0.8.5
  Fixes #369 thread issue when calling translate with fallbacks
  Remove gemfiles/Gemfile.*.lock from the repo
  Improve error message for missing pluralization key
  Bump to 0.8.4
  Revert "Don't allow nil to be submitted as a key to i18n.translate()"
  Bump to 0.8.3
  Update Changelog
  Handle false as a key correctly
  Bump Gemfiles
  Bump to 0.8.2
  Add Gemfile.lock for each Rails version
  Bump to 0.8.1
  Fix transliteration to default replacement char
  Docs: Add 0.8.0 to changelog
  No need to skip ruby 2.4+ x rails 4 now
  CI against newest stable rubies for each minor version
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@radar