Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect number of inspected files #5822

Closed
revolter opened this issue Apr 25, 2018 · 3 comments
Closed

Incorrect number of inspected files #5822

revolter opened this issue Apr 25, 2018 · 3 comments

Comments

@revolter
Copy link
Contributor

revolter commented Apr 25, 2018 •
edited
Loading

Expected behavior

It should inspect all the passed files.

Actual behavior

It inspects only a part of the files.

Steps to reproduce the problem

Running:

bundle exec rubocop Gemfile fastlane/globals.rb Podfile fastlane/Deliverfile fastlane/Pluginfile fastlane/Gymfile fastlane/Fastfile fastlane/Appfile Brewfile

prints:

Inspecting 6 files
......

6 files inspected, no offenses detected

but it should inspect all the 9 files instead.

Running only bundle exec rubocop correctly inspects all the 9 files.

RuboCop version

0.55.0
@jgrau
Copy link

jgrau commented May 17, 2018 •
edited
Loading

I am experiencing the same. On 0.56.0 running rubocop only inspects 2 files while it previously inspected all files (hundreds). Reverting to 0.55.0 fixes the issue for me.

@bbatsov
Copy link
Collaborator

bbatsov commented May 17, 2018

See #4247

We made a breaking change that dealt with some nasty legacy - some file types were hardcoded in RuboCop and we wanted to make everything configurable. People who had modified the default Include/Exclude patterns are affected by this change.

@jgrau
Copy link

jgrau commented May 19, 2018

Awesome. That fixed my issue.

cupakromer added a commit to RadiusNetworks/radius-spec that referenced this issue Jun 14, 2018
@cupakromer
Remove include from common rubocop config
dfa52bb 
I'm not sure why we added this in the first place. Looking at the
Rubocop default setup these files have been included for over a year
now. This custom include also breaks Rubocop 0.56.0 due to changes in
how it handles the merging (it no longer merges include by default for
the all cops setting).

For more details see:

  - [Incorrect number of inspected files](rubocop/rubocop#5822)
  - [Ability to specify files/directories to look at and ignore everything else](rubocop/rubocop#4247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbatsov @jgrau @revolter