This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Enforce an object return from selectFromResult
#216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
selectFromResult
always returns an object, not a primitiveI'd found a lovely edge case in my own app where I had:
Unfortunately, due to how the result stuff gets merged together later, I ended up with
number & BunchOfResultData
, which is of course not valid at all. I had to ensure that I returned the value inside an object.So, now we enforce that at the type level too.