Create new Federation and the complete process until it is confirmed and activated #2925
+411
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mitProposedFederation
…s named FederationChangeIT.java
…ed until activation phase
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
apancorb
changed the title
jeremy-then
reviewed
Jan 10, 2025
| private FederationSupportImpl federationSupport; | ||
| private LockingCapSupport lockingCapSupport; | ||
| private BridgeSupport bridgeSupport; | ||
|
|
There was a problem hiding this comment.
Can we put the List<Triple<BtcECKey, ECKey, ECKey>> variables after this? Those are much more complex initializations. Let's put them last so they are not in the middle of simple variable declarations.
jeremy-then
reviewed
Jan 10, 2025
| case P2SH_ERP -> { | ||
| originalFederation = FederationFactory.buildP2shErpFederation( | ||
| originalFederationArgs, erpPubKeys, activationDelay); | ||
| // TODO: CHECK REDEEMSCRIPT |
There was a problem hiding this comment.
Should this TODO be here still?
jeremy-then
reviewed
Jan 10, 2025
| private BridgeSupport bridgeSupport; | ||
|
|
||
| @Test | ||
| void whenAllActivationsArePresentAndFederationChanges_shouldCreateNewActiveFederation() throws Exception { |
There was a problem hiding this comment.
Suggested change
| void whenAllActivationsArePresentAndFederationChanges_shouldCreateNewActiveFederation() throws Exception { | |
| void whenAllActivationsArePresentAndFederationChanges_shouldMakeTheProposedFederationTheNewActiveFederation() throws Exception { |
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea is to provide building blocks that can be reused while creating new tests. This focuses on creating a new active and retiring federation.