Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed method getLockWhitelistEntry so it returns an optional #2912

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

julianlen
Copy link
Contributor

No description provided.

@julianlen julianlen requested a review from a team as a code owner January 2, 2025 18:43
Copy link

github-actions bot commented Jan 2, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@julianlen julianlen force-pushed the whitelistSupport-refactor branch from 3fc4c1f to 4220bfb Compare January 2, 2025 18:55
@julianlen julianlen changed the title feat: changed method getLockWhitelistEntryByAddress so it returns an optional feat: changed method getLockWhitelistEntry so it returns an optional Jan 3, 2025
@marcos-iov marcos-iov force-pushed the whitelistSupport-refactor branch from b0c99e3 to ef766e1 Compare January 8, 2025 19:46
@marcos-iov
Copy link
Contributor

Looks like unit tests are failing, please check that

@julianlen julianlen force-pushed the whitelistSupport-refactor branch from ef766e1 to c1872b1 Compare January 9, 2025 19:23
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@julianlen julianlen requested a review from marcos-iov January 9, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants