Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to extractWitnessCommitmentHash in the Bridge #2890

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

marcos-iov
Copy link
Contributor

Relates to rsksmart/bitcoinj-thin#125

Description

Since now the logic to get the witness commitment from a coinbase transaction is in the Bridge, it's necessary to also add extractWitnessCommitmentHash and avoid dependency to bitcoinj-thin

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@marcos-iov marcos-iov requested a review from a team as a code owner December 11, 2024 19:58
Copy link

github-actions bot commented Dec 11, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

@apancorb apancorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcos-iov marcos-iov force-pushed the add-extractWitnessCommitmentHash branch from 8184a36 to 685c25a Compare January 6, 2025 17:40
@josedahlquist josedahlquist merged commit c5e3dc4 into master Jan 6, 2025
13 checks passed
@marcos-iov marcos-iov deleted the add-extractWitnessCommitmentHash branch January 6, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants