Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the parameter out to opq to select the level of verbosity of the results #288

Merged
merged 6 commits into from
Dec 14, 2022

Conversation

jmaspons
Copy link
Collaborator

@jmaspons jmaspons commented Dec 6, 2022

I can replicate the option for opq_osm_id, opq_enclosing and opq_around

@jmaspons
Copy link
Collaborator Author

jmaspons commented Dec 6, 2022

Checks fail due to a link in the documentation to osmdata_data_frame which is not merged yet #285

@jmaspons
Copy link
Collaborator Author

From my side, ready for the merge @mpadge

P.S.: Don't know why there are no test coverage checks from the gh actions anymore

R/opq.R Outdated Show resolved Hide resolved
R/opq.R Outdated Show resolved Hide resolved
jmaspons and others added 2 commits December 14, 2022 11:32
Simplify expression for suffix for non-geometric outputs

Co-authored-by: mark padgham <[email protected]>
@mpadge
Copy link
Member

mpadge commented Dec 14, 2022

I approved those changes, but then discovered that the tests are all failing. Can you please fix those, then i'll merge? Thanks

@jmaspons
Copy link
Collaborator Author

Thanks for the review. I have rewritten this part by testing the condition for has_geometry adding nodes_only, and build the suffix from scratch. This makes the tests fails because they expect that queries with nodes_only have no "body" in the string, which is the default anyway. This limit queries with nodes_only and out meta;. I have changed the tests

@mpadge mpadge merged commit 83a874d into ropensci:main Dec 14, 2022
@jmaspons jmaspons deleted the out branch February 2, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants