Skip to content

Commit

Permalink
update cran-comments [skip ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
mpadge committed Mar 22, 2021
1 parent f2b8338 commit 1871a89
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 11 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: osmdata
Title: Import 'OpenStreetMap' Data as Simple Features or Spatial Objects
Version: 0.1.4.042
Version: 0.1.4.044
Authors@R:
c(person(given = "Mark",
family = "Padgham",
Expand Down
2 changes: 1 addition & 1 deletion codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"codeRepository": "https://github.com/ropensci/osmdata/",
"issueTracker": "https://github.com/ropensci/osmdata/issues",
"license": "https://spdx.org/licenses/GPL-3.0",
"version": "0.1.4.042",
"version": "0.1.4.044",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
Expand Down
16 changes: 7 additions & 9 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
# CRAN notes for osmdata_0.1.4 submission
# CRAN notes for osmdata_0.1.5 submission

This submission attempts to once again fix URL redirects. Please note that a previous attempt to submit this version complied with instructions to redirect http://srtm.csi.cgiar.org/ to https, but the https server generally times out and errors. This submission reverts all of those URLs to "http" and not "https". Even then, the server is very slow, and may not respond to automated status queries. This URL is nevertheless only given in documentation, and not directly called by any functions within the package. Slowness or errors in responding to this URL thus do not affect package functionality in any way.

The submission also fixes an intermittent error in previous version which called an occasionally unreliable URL in one example. That call has now been \dontrun{}.

One NOTE is generated on some systems regarding installed size, which is unavoidable due to very large C++ code base.
CRAN win-builder generates one note on some systems regarding a possibly valid
URL at https://overpass-api.de/api/interpreter/, because of a tlsvl alert
protocol version. The associated URL is valid, but can not be queried with an
empty body, which is perhaps the reason your CRAN tests generate this note?

## Test environments

Other than the above, this submission generates NO notes on:
* Linux (via Travis-ci): R-release, R-devel, R-oldrelease
* OSX (via Travis-ci): R-release
* Windows Visual Studio 2015 x64 (via appveyor)
* Linux (via github actions): R-release, R-oldrelease
* Windows (via github actions): R-release, R-oldrelease, R-devel
* win-builder: R-oldrelease, R-release, R-devel

Package also checked using `Clang++ -Weverything`, and both local memory sanitzer and `rocker/r-devel-san` with clean results.

0 comments on commit 1871a89

Please sign in to comment.