Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix includes and define IMWRITE_PNG_COMPRESSION and IMWRITE_JPEG_QUALITY in cv:: namespace #18

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Fix includes and define IMWRITE_PNG_COMPRESSION and IMWRITE_JPEG_QUALITY in cv:: namespace #18

merged 2 commits into from
Jun 10, 2021

Conversation

nunoguedelha
Copy link
Collaborator

@nunoguedelha nunoguedelha commented Jun 8, 2021 •
edited
Loading

Fixes #17 .

@nunoguedelha nunoguedelha mentioned this pull request Jun 8, 2021
Closed
@nunoguedelha
Copy link
Collaborator Author

CC @Nicogene @vtikha

@nunoguedelha nunoguedelha mentioned this pull request Jun 10, 2021
Closed
@traversaro
Copy link
Member

I think probably the fix is related to a recent OpenCV rather then a recent YARP, but it any case it probably make sense to merge it.

@traversaro traversaro requested review from vtikha and traversaro and removed request for vtikha June 10, 2021 15:17
@traversaro traversaro merged commit 33167ec into robotology:master Jun 10, 2021
@traversaro
Copy link
Member

@cciliber we are finally starting using yarp.js as I promised years ago :D

@nunoguedelha
Copy link
Collaborator Author

Thanks @traversaro

@nunoguedelha nunoguedelha deleted the fix/typo-in-include-cv-header branch June 10, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@nunoguedelha nunoguedelha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yarp.js build broken on YARP v3.4.3
2 participants
@nunoguedelha @traversaro