Upgrade to go-redis/v8 #17
Open
+117
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been a number of fixes to go-redis for Redis Cluster compatibility. Notably, [1], which impacts the node go-redis chooses to send a stream command to. We're continuing to see `MOVED` errors emitted from redisqueue, despite not overriding `MaxRedirects` when constructing our redis client. This suggests to me that the choice of initial node may be to blame. This commit updates redisqueue to use go-redis/v8. In order to avoid signature changes, we use `context.TODO()` liberally. [1] redis/go-redis#1501
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a number of fixes to go-redis for Redis Cluster
compatibility. Notably, [1], which impacts the node go-redis chooses
to send a stream command to.
We're continuing to see
MOVEDerrors emitted from redisqueue,despite not overriding
MaxRedirectswhen constructing our redisclient. This suggests to me that the choice of initial node may be to
blame.
This commit updates redisqueue to use go-redis/v8. In order to avoid
signature changes, we use
context.TODO()liberally.[1] redis/go-redis#1501