Fix parsing of GDB <reg> tags not separated by whitespace #4273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
regstr_end + 3
would advance into the next<reg>
tag if there is no whitespace between the two tags. This would cause the latter register to be ignored by the parser. Such an XML is for example used by mGBA's GDB stub.Test plan
In one terminal:
In another terminal:
Verify that the register list is complete for your architecture.
For testing with mGBA, which generates the problematic XML:
rizin -c dr -D gdb gdb://localhost:2345
r0, r1, r2, r3, r4, r5, r6, r7, r8, r9, r10, r11, r12, sp, lr, pc, cpsr
(currently in the dev branch, the odd-numbered registers are omitted)