-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gameboy RzIL Lifting #3750
Merged
Merged
Gameboy RzIL Lifting #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestr4ng3r
force-pushed
the
gb-il
branch
2 times, most recently
from
August 30, 2023 17:45
ba51685
to
a5954de
Compare
Bikeshed: how about renaming |
The plugin also contains some Gameboy-specific logic, like for memory mapping, which is not necessarily related to the sm83 itself so I find gb to be slightly more accurate here. |
Thanks for explanation. It makes sense then. |
thestr4ng3r
force-pushed
the
gb-il
branch
4 times, most recently
from
September 6, 2023 15:56
a8978b9
to
62bcaee
Compare
thestr4ng3r
requested review from
wargio,
XVilka,
kazarmy and
ret2libc
as code owners
September 9, 2023 09:50
XVilka
approved these changes
Sep 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squash this
This adds RzIL lifting for all Game Boy (SM83) instructions, including asm tests for each.
Tracetesting was done with SameBoy, which is one of the most accurate emulators (https://daid.github.io/GBEmulatorShootout/), on the following roms:
bins/gb/emulateme.gb
A small emulation example (
test/db/rzil/gb
) where a short string is decrypted in memory is added as well.