Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gameboy RzIL Lifting #3750

Merged
merged 28 commits into from
Sep 10, 2023
Merged

Gameboy RzIL Lifting #3750

merged 28 commits into from
Sep 10, 2023

Conversation

thestr4ng3r
Copy link
Member

@thestr4ng3r thestr4ng3r commented Aug 13, 2023

squash this

This adds RzIL lifting for all Game Boy (SM83) instructions, including asm tests for each.

Tracetesting was done with SameBoy, which is one of the most accurate emulators (https://daid.github.io/GBEmulatorShootout/), on the following roms:

A small emulation example (test/db/rzil/gb) where a short string is decrypted in memory is added as well.

@omasanori
Copy link

Bikeshed: how about renaming gb to sm83?

@thestr4ng3r
Copy link
Member Author

The plugin also contains some Gameboy-specific logic, like for memory mapping, which is not necessarily related to the sm83 itself so I find gb to be slightly more accurate here.

@omasanori
Copy link

Thanks for explanation. It makes sense then.

@thestr4ng3r thestr4ng3r force-pushed the gb-il branch 4 times, most recently from a8978b9 to 62bcaee Compare September 6, 2023 15:56
@thestr4ng3r thestr4ng3r marked this pull request as ready for review September 9, 2023 09:50
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thestr4ng3r thestr4ng3r merged commit 9872eac into dev Sep 10, 2023
@thestr4ng3r thestr4ng3r deleted the gb-il branch September 10, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants