Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risc0-build: Allow to pass custom env variables to build container #2709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Jan 7, 2025

No description provided.

@Wiezzel Wiezzel requested a review from a team as a code owner January 7, 2025 16:06
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 7, 2025 4:07pm

Copy link

vercel bot commented Jan 7, 2025

@Wiezzel is attempting to deploy a commit to the RISC Zero Team on Vercel.

A member of the Team first needs to authorize it.

@flaub
Copy link
Member

flaub commented Jan 8, 2025

These are great features to add, however they are done in a way that breaks compatibility with 1.0 semver of the risc-build crate. I have an upcoming PR that should land soon which 1) bumps the major version to 2.0.0 and 2) makes some breaking changes. I'd like to get this PR in first but then I think we can land this ontop.

#2704

@Wiezzel
Copy link
Author

Wiezzel commented Jan 9, 2025

@flaub What do you think about introducing a builder for DockerOptions and GuestOptions and making the default constructor private so that new options can be added in the future without breaking compatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants