fixed crash when no content-type #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed crash when no content-type
king-d-dev
reviewed
Nov 21, 2023
| @@ -29,7 +29,7 @@ const hasAcceptableMethod = (req) => !UNACCEPTABLE_METHODS.has(req.method); | |||
| */ | |||
| const hasAcceptableContentType = (req) => { | |||
| const contType = req.headers['content-type']; | |||
| return contType.includes('boundary=') && ACCEPTABLE_CONTENT_TYPE.test(contType); | |||
| return contType && contType.includes('boundary=') && ACCEPTABLE_CONTENT_TYPE.test(contType); | |||
There was a problem hiding this comment.
Suggested change
| return contType && contType.includes('boundary=') && ACCEPTABLE_CONTENT_TYPE.test(contType); | |
| return !!contType?.includes('boundary=') && ACCEPTABLE_CONTENT_TYPE.test(contType); |
reason for this suggestion is that, the initial implementation you provided has potential to cause the function to return the undefined or null or whatever falsy value that contType could potentially be. Kindly refer to the small demo i showed in the screenshot below for reference.
|
Thanks, for checking this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed crash when no content-type
to replicate just make a request like this, and it will crash
curl -v https://example.com/xxx -d '1' -H 'Content-Type:'