Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edns certs stage2 w initramfs r10 #6082

Draft
wants to merge 14 commits into
base: rhel-10
Choose a base branch
from
Draft

Edns certs stage2 w initramfs r10 #6082

wants to merge 14 commits into from

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Jan 7, 2025 •
edited
Loading

Port of #6045
The only difference from the upstream PR is import statements cleanup happened there.

KKoukiou and others added 14 commits January 7, 2025 09:40
@KKoukiou @rvykydal
security: implement the support to install certificates to Anaconda
5d4176e 
Kickstart %certificate section is used.
Submodule, data structures, parsing.

Resolves: INSTALLER-4030

Patch modified by rvykydal.
@rvykydal
kickstart: extend section specification for list of section data
8975915 
Unlike the %packages section where the data of all sections are merged
into single data object the %certificates section holds the per
instance section data in a list.

Related: INSTALLER-4030
@rvykydal
security: add API: Certificate getter
5c5ff63 
Resolves: INSTALLER-4030
@rvykydal
security: add API to import certificates to Anaconda environment
f08f806 
Related: INSTALLER-4030
@rvykydal
security: import certificates early after Anaconda start
e7df022 
The certificates imported in initramfs are already imported earlier by a
service.

Resolves: INSTALLER-4030
@rvykydal
security: Add API for installation on target system
1186f24 
Resolved: INSTALLER-4030
@rvykydal
security: install certificates on target system
d052e01 
Resolves: INSTALLER-4030
@rvykydal
security: add API to install certificates early before payload
983748c 
In case they are needed or processed by package scriptlets

Resolves: INSTALLER-4030
@rvykydal
security: pre-install certificates before payload installation
86868eb 
Resolves: INSTALLER-4030
@rvykydal
security: log a warning when dumping certificate over an existing file
db52e36 
Resolves: INSTALLER-4030
@rvykydal
security: raise exception if certificate destination is unknown
47f672e 
Don't require it on parsing level, don't own a default.

Resolves: INSTALLER-4030
@rvykydal
security: install certificates in pre-install phase only for dnf payload
f96a8ad 
Resolves: INSTALLER-4030
@rvykydal
security: import certificates in initramfs
414fabc 
Also dump for transfer durig switchroot so that the certificates
can be potentially imported early after switchroot by a service.

Resolves: INSTALLER-4030
@rvykydal
security: add service to transfer certificates from initramfs
509aa47 
Resolves: INSTALLER-4030
@rvykydal rvykydal requested review from M4rtinK and jkonecny12 January 9, 2025 08:55
jkonecny12
jkonecny12 requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me code wise.

However, it has wrong Resolves in the commit message.

Optional, you may want to change the license headers to 2025 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkonecny12 jkonecny12 jkonecny12 requested changes

@M4rtinK M4rtinK Awaiting requested review from M4rtinK

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
rhel-10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvykydal @jkonecny12 @KKoukiou