RHEL-10: Do not crash if RDP is selected after regular GUI startup failed #6037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…26410) The ask_rd_question() function returns not only the credentials tuple, but also the "use remote desktop" flag. We correctly handled that in the regular case where we ask for user password if user selected RDP instead of text mode. But we missed that in the harder to test case where RDP is suggested as an option to the user after regular locally running GUI startup fails. Oops! :P So handle the extra value and avoid the crash. :) Resolves: rhbz#2326410 Resolves: RHEL-69940 (cherry picked from commit d550aa1)
The ask rdp questions dialog methods in display.py were setting display mode and flags which wasn't visible before. Let's make it obvious in the code so we don't forget about such an issue as before. (cherry picked from commit 4863cc6) Related: RHEL-69940
|
/kickstart-test --testtype smoke |
|
/kickstart-test ui_rdp |
|
/kickstart-test --testtype coverage |
|
Tested locally - works as expected. |
jkonecny12
added
the
ready to merge
|
Setting ready_to_merge even thought it needs review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ask_rd_question()function returns not only the credentials tuple, but also the "use remote desktop" flag.We correctly handled that in the regular case where we ask for user password if user selected RDP instead of text mode.
But we missed that in the harder to test case where RDP is suggested as an option to the user after regular locally running GUI startup fails. Oops! :P
So handle the extra value and avoid the crash. :)
Backport of #5999
Resolves: RHEL-69940