Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use image-url when resolving CSS? #159

Open
n0nick opened this issue Jul 31, 2015 · 0 comments
Open

Why not use image-url when resolving CSS? #159

n0nick opened this issue Jul 31, 2015 · 0 comments

Comments

@n0nick
Copy link

n0nick commented Jul 31, 2015

In #49 the rake bower:resolve task was introduced, which replaces any url(some_asset) with a url(<%= asset_path('some_asset') %>) ERB code.

At least for CSS (and Sass), this can be achieved much more cleanly using the asset-url and asset-path helpers -- i.e. converting the above to asset-url(some_asset).

Apart from being a cleaner solution, it also avoids using ERB in the process (since Assets Pipeline already knows to handle this in regular CSS files).

I'm wondering if this can be considered? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant