refactor: Typed timestamp utility #33512
Open
+134
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
changed the title
viceice
reviewed
Jan 10, 2025
|
|
||
| export function asTimestamp(input: unknown): Timestamp | null { | ||
| if (input instanceof Date) { | ||
| const date = DateTime.fromJSDate(input, { zone: 'UTC' }); |
There was a problem hiding this comment.
don't we change the timezone to a probably wrong value here? or is datetime correctly converting it.
There was a problem hiding this comment.
It's converted from whatever timezone the original value is, to the UTC
| return millisDate.toISO() as Timestamp; | ||
| } | ||
|
|
||
| const secondsDate = DateTime.fromSeconds(input, { zone: 'UTC' }); |
There was a problem hiding this comment.
If some datasource is capable of providing timestamp in the millisecond format, I could imagine it's done in the seconds format as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: