-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preset): netflix dgs spring starters #33447
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Co-authored-by: Rhys Arkins <[email protected]>
Co-authored-by: Rhys Arkins <[email protected]>
"description": "`dgs-framework` migrated to new `spring-graphql` starters.", | ||
"packageRules": [ | ||
{ | ||
"matchCurrentVersion": "[9.2.2,)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test locally that this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing now with https://github.com/setchy/test-dgs-replacement/pulls
Thinking out loud, might need changes since you can either use the deps directly, or by using the BOM com.netflix.graphql.dgs:graphql-dgs-platform-dependencies
as https://github.com/setchy/test-dgs-replacement/pulls demonstrates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to draft
status until I have time to fully test locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think replacement PRs are currently not expected to work with maven
manager:
renovate/lib/modules/manager/maven/update.ts
Lines 41 to 44 in ac9ddf3
if (upgrade.updateType === 'replacement') { | |
logger.warn('maven manager does not support replacement updates yet'); | |
return null; | |
} |
PR ##32635 has the potential to change this
Changes
Add migration present for Netflix DGS Framework starters
Context
See https://github.com/Netflix/dgs-framework/releases/tag/v10.0.0 release notes.
From 10.x they consolidated a number of their starters
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: