Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset): netflix dgs spring starters #33447

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Jan 7, 2025

Changes

Add migration present for Netflix DGS Framework starters

Context

See https://github.com/Netflix/dgs-framework/releases/tag/v10.0.0 release notes.

From 10.x they consolidated a number of their starters

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/data/replacements.json Outdated Show resolved Hide resolved
lib/data/replacements.json Outdated Show resolved Hide resolved
lib/data/replacements.json Show resolved Hide resolved
setchy and others added 2 commits January 7, 2025 10:07
"description": "`dgs-framework` migrated to new `spring-graphql` starters.",
"packageRules": [
{
"matchCurrentVersion": "[9.2.2,)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test locally that this works?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing now with https://github.com/setchy/test-dgs-replacement/pulls

Thinking out loud, might need changes since you can either use the deps directly, or by using the BOM com.netflix.graphql.dgs:graphql-dgs-platform-dependencies as https://github.com/setchy/test-dgs-replacement/pulls demonstrates

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to draft status until I have time to fully test locally

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think replacement PRs are currently not expected to work with maven manager:

if (upgrade.updateType === 'replacement') {
logger.warn('maven manager does not support replacement updates yet');
return null;
}

PR ##32635 has the potential to change this

@setchy setchy marked this pull request as draft January 7, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants