refactor: separate npm extract functions #24455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
commented
Sep 16, 2023
lib/modules/manager/npm/extract/__snapshots__/index.spec.ts.snap
Outdated
Show resolved
Hide resolved
|
I'm using this branch to implement bun support off, and may still have some changes before then. This approach will be helpful for the later npm manager separation |
See: |
viceice
previously approved these changes
Sep 16, 2023
rarkins
force-pushed
the
refactor/npm-extract
branch
2 times, most recently
from
a71371e to
15aaca5
Compare
rarkins
changed the title
rarkins
force-pushed
the
refactor/npm-extract
branch
from
15aaca5 to
b66189b
Compare
viceice
approved these changes
Sep 18, 2023
|
🎉 This PR is included in version 36.96.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Refactors npm extract functions
Context
Preparation for npm manager separation + bun
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: