refactor(migrations): migrate depTypes

lib/config/__snapshots__/migration.spec.ts.snap

@@ -215,36 +215,36 @@ Object {
         "examples/**",
       ],
     },
-    Object {
-      "matchDepTypes": Array [
-        "peerDependencies",
-      ],
-      "rangeStrategy": "widen",
-    },
     Object {
       "major": Object {
         "automerge": false,
       },
       "matchDepTypes": Array [
-        "devDependencies",
+        "optionalDependencies",
       ],
       "minor": Object {
         "automerge": true,
       },
-      "schedule": null,
+      "respectLatest": false,
+      "schedule": "before 5am on Monday",
+    },
+    Object {
+      "matchDepTypes": Array [
+        "peerDependencies",
+      ],
+      "rangeStrategy": "widen",
     },
     Object {
       "major": Object {
         "automerge": false,
       },
       "matchDepTypes": Array [
-        "optionalDependencies",
+        "devDependencies",
       ],
       "minor": Object {
         "automerge": true,
       },
-      "respectLatest": false,
-      "schedule": "before 5am on Monday",
+      "schedule": null,
     },
   ],
   "patch": Object {

lib/config/migration.ts

@@ -38,6 +38,7 @@ export function migrateConfig(config: RenovateConfig): MigratedConfig {
       'optionalDependencies',
       'peerDependencies',
     ];
+
     for (const [key, val] of Object.entries(newConfig)) {
       if (depTypes.includes(key)) {
         migratedConfig.packageRules = is.array(migratedConfig.packageRules)
@@ -70,26 +71,6 @@ export function migrateConfig(config: RenovateConfig): MigratedConfig {
           '{{semanticPrefix}}',
           '{{#if semanticCommitType}}{{semanticCommitType}}{{#if semanticCommitScope}}({{semanticCommitScope}}){{/if}}: {{/if}}'
         );
-      } else if (key === 'depTypes' && is.array(val)) {
-        val.forEach((depType) => {
-          if (is.object(depType) && !is.array(depType)) {
-            const depTypeName = (depType as any).depType;
-            if (depTypeName) {
-              migratedConfig.packageRules = is.array(
-                migratedConfig.packageRules
-              )
-                ? migratedConfig.packageRules
-                : [];
-              const newPackageRule = migrateConfig(
-                depType as RenovateConfig
-              ).migratedConfig;
-              delete newPackageRule.depType;
-              newPackageRule.depTypeList = [depTypeName];
-              migratedConfig.packageRules.push(newPackageRule);
-            }
-          }
-        });
-        delete migratedConfig.depTypes;
       } else if (optionTypes[key] === 'object' && is.boolean(val)) {
         migratedConfig[key] = { enabled: val };
       } else if (optionTypes[key] === 'boolean') {

lib/config/migrations/custom/dep-types-migration.spec.ts

@@ -0,0 +1,83 @@
+import { DepTypesMigration } from './dep-types-migration';
+
+describe('config/migrations/custom/dep-types-migration', () => {
+  it('should only add depTypes to packageRules', () => {
+    expect(DepTypesMigration).toMigrate(
+      {
+        peerDependencies: {
+          versionStrategy: 'widen',
+        },
+        depTypes: [
+          'dependencies',
+          {
+            depType: 'optionalDependencies',
+            respectLatest: false,
+          },
+        ],
+        packageRules: [
+          {
+            packagePatterns: '^(@angular|typescript)' as never,
+            groupName: ['angular packages'] as never,
+            excludedPackageNames: 'foo',
+          },
+          {
+            packageNames: ['foo'],
+            packageRules: [
+              {
+                depTypeList: ['bar'],
+                automerge: true,
+              },
+            ],
+          },
+        ],
+      },
+      {
+        peerDependencies: {
+          versionStrategy: 'widen',
+        },
+        packageRules: [
+          {
+            packagePatterns: '^(@angular|typescript)' as never,
+            groupName: ['angular packages'] as never,
+            excludedPackageNames: 'foo',
+          },
+          {
+            packageNames: ['foo'],
+            packageRules: [
+              {
+                depTypeList: ['bar'],
+                automerge: true,
+              },
+            ],
+          },
+          {
+            depTypeList: ['optionalDependencies'],
+            respectLatest: false,
+          },
+        ],
+      }
+    );
+  });
+
+  it('should migrate depTypes', () => {
+    expect(DepTypesMigration).toMigrate(
+      {
+        depTypes: [
+          'dependencies',
+          {
+            depType: 'optionalDependencies',
+            respectLatest: false,
+          },
+        ],
+      },
+      {
+        packageRules: [
+          {
+            depTypeList: ['optionalDependencies'],
+            respectLatest: false,
+          },
+        ],
+      }
+    );
+  });
+});

lib/config/migrations/custom/dep-types-migration.ts

@@ -0,0 +1,27 @@
+import is from '@sindresorhus/is';
+import type { PackageRule } from '../../types';
+import { AbstractMigration } from '../base/abstract-migration';
+
+export class DepTypesMigration extends AbstractMigration {
+  override readonly deprecated = true;
+  override readonly propertyName = 'depTypes';
+
+  override run(value: unknown): void {
+    const packageRules: PackageRule[] = this.get('packageRules') ?? [];
+    if (is.array(value)) {
+      for (const depType of value) {
+        if (is.object(depType) && !is.array(depType)) {
+          const depTypeName = (depType as any).depType;
+          if (depTypeName) {
+            delete (depType as any).depType;
+            (depType as any).depTypeList = [depTypeName];
+            packageRules.push({ ...(depType as PackageRule) });
+          }
+        }
+      }
+    }
+    if (packageRules.length) {
+      this.setHard('packageRules', packageRules);
+    }
+  }
+}

lib/config/migrations/migrations-service.ts

@@ -15,6 +15,7 @@ import { BranchNameMigration } from './custom/branch-name-migration';
 import { BranchPrefixMigration } from './custom/branch-prefix-migration';
 import { CompatibilityMigration } from './custom/compatibility-migration';
 import { ComposerIgnorePlatformReqsMigration } from './custom/composer-ignore-platform-reqs-migration';
+import { DepTypesMigration } from './custom/dep-types-migration';
 import { DryRunMigration } from './custom/dry-run-migration';
 import { EnabledManagersMigration } from './custom/enabled-managers-migration';
 import { ExtendsMigration } from './custom/extends-migration';
@@ -130,6 +131,7 @@ export class MigrationsService {
     DryRunMigration,
     RequireConfigMigration,
     PackageFilesMigration,
+    DepTypesMigration,
     NodeMigration,
     SemanticPrefixMigration,
   ];