Use docker in CI; Don't echo random number if pipe is closed #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/os_test.yml
Outdated
| run: make test | ||
| - run: | | ||
| docker build -t course_os . | ||
| docker run course_os make test |
There was a problem hiding this comment.
don't you need to install docker as a dependency? I don't think ubuntu comes with it by default
There was a problem hiding this comment.
I would think so as well, but the Github CI docs specify that the image indeed includes it.
There was a problem hiding this comment.
oh sure, that's fine then
|
You should be able to merge your own PR now! |
|
Pulled the commit and it works fine |
NULLx76
pushed a commit
that referenced
this pull request
Nov 29, 2024
Use docker in CI; Don't echo random number if pipe is closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI errors.