Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link in docs to 'several reasons' (at normalization mentions) is broken #3240

Closed
mefjuu opened this issue Dec 7, 2018 · 0 comments
Closed

Link in docs to 'several reasons' (at normalization mentions) is broken #3240

mefjuu opened this issue Dec 7, 2018 · 0 comments

Comments

@mefjuu
Copy link

mefjuu commented Dec 7, 2018 •
edited
Loading

There is a 404 link in docs: https://redux.js.org/faq/performance#will-caching-remote-data-cause-memory-problems
A 'serveral reasons' link leads to 404: https://github.com/reduxjs/redux/tree/864b9c32332ca19511d5cabb0e927d340744e4fa/docs/recipes/reducers/NormalizingStateShape.html#designing-a-normalized-state
@timdorr timdorr closed this as completed in 71e458d Dec 7, 2018
markerikson added a commit that referenced this issue Dec 8, 2018
@markerikson
Rework new docs site landing page (#3267)
ee71d78 
* -dprctd react-router-redux +connected-react-router (#3237)

* -dprctd react-router-redux +connected-react-router

removed... 
**[ReactTraining/react-router-redux](https://github.com/ReactTraining/react-router/tree/master/packages/react-router-redux)**  
Keep your state in sync with your router

 According to their page:  """"Redux users: The react-router-redux package is now deprecated."""""

* Simplify description

* Fix wrong anchor in Store documentation (#3238)

The anchor wasn't matching the target element so it wasn't scrolling.

* Fix link.

Closes #3240

* Removed unnecessary semicolon (#3264)

* Fit bindActionCreators docs more clearly (#3266)

Fix typo - object arguments to object properties
Clear words - single function to action creator for bindActionCreatorss first argument

* Add docs survey link

* Update package-lock.json

* Disable broken separate codeblock CSS link

This is already getting imported directly, and the generated
separate link 404s in prod.

* Tweak header/footer links styles some more

* Add missing "sub-apps" page link

* Add starter kit mentions to "Getting Started"

* Add main logo sales pitch blocks

Added Redux logo next to the main title
Removed "Installation" line
Added selling point headers and paragraphs
Added some Font Awesome icons and a copyright link

* Switch out a couple icons and bump icon sizes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mefjuu