Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 Integration branch #3089

Merged
merged 548 commits into from
Dec 4, 2023
Merged

v2.0 Integration branch #3089

merged 548 commits into from
Dec 4, 2023

Conversation

markerikson
Copy link
Collaborator

This is an ongoing integration branch for all of the RTK 2.0 development work.

(second attempt, because Github accidentally closed the other one.)

@codesandbox
Copy link

codesandbox bot commented Jan 14, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 14, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0fa46d4:

Sandbox Source
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@netlify
Copy link

netlify bot commented Jan 14, 2023

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 0fa46d4
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/656d4ee94956de0008eb4037
😎 Deploy Preview https://deploy-preview-3089--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FaberVitale
Copy link
Contributor

Hi Mark,

I've seen that you're migrating Toolkit to type: module.

It seems well done but I have a question:

do you need to publish one by one "@reduxjs/toolkit-query and the other sub-packages or it's not needed?

do you just need to publish the top level package (Toolkit)?

@markerikson
Copy link
Collaborator Author

@FaberVitale : there's only one actual package - @reduxjs/toolkit :) The /query and /query/react entry points are all part of the same published package:

Also, I had a couple meetings last week with Andarist and with a TS team member, who gave me advice on what we should do for proper ESM support. Notably, one suggestion is to drop type: "module" from the main package.json, as it doesn't really help. See these notes:

@markerikson markerikson force-pushed the v2.0-integration branch 3 times, most recently from 1348302 to 157536c Compare March 25, 2023 18:58
jherr and others added 26 commits November 24, 2023 15:12
- Updated title
- Changed "NextJS" to "Next.js" to match their naming
- Added recommendation on folder structure
- Updated examples to match that folder structure
- Added typed hooks setup and usage
- Renamed `StoreType` to `AppStore`
- Updated store init to always use `if (!storeRef.current)`
- Updated section headers
- Added "RTKQ doesn't do SSR yet" callout
@markerikson markerikson marked this pull request as ready for review December 4, 2023 04:49
@markerikson
Copy link
Collaborator Author

[Ready for Review]

click

"LGTM"

🚢 🚢 :shipit:

@markerikson markerikson merged commit 350e79f into master Dec 4, 2023
43 checks passed
@markerikson markerikson deleted the v2.0-integration branch December 4, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants