Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce sleep time to resolve test failing issue #1718

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Reduce sleep time to resolve test failing issue #1718

merged 1 commit into from
Dec 22, 2017

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Dec 19, 2017 •
edited
Loading

Recent PRs are failing after these lines.

@sazzad16 sazzad16 added this to the 2.10.0 milestone Dec 19, 2017
@sazzad16
Copy link
Collaborator Author

@HeartSaVioR @marcosnils

@marcosnils
Copy link
Contributor

@sazzad16 wondering why's the reason that reducing the sleep makes it work.

@sazzad16
Copy link
Collaborator Author

@marcosnils Your guess is as good as mine.
I played with different combinations of Jedis timeout, sleep time and Redis timeout. This turned out to be the minimal change that worked every the time in travis.

@marcosnils
Copy link
Contributor

If this makes tests more reliable then LGTM!

@sazzad16
Copy link
Collaborator Author

@marcosnils I won't say this is a reliable fix but more of a quick fix.

Travis builds are failing for all the PRs. I thought it'd be a good idea to have a quick fix. We may create an issue to dig into this.

@sazzad16
Copy link
Collaborator Author

From December 12th, 2017, Travis jobs are running in Trusty environment. This could be the reason. PRs before this date were passing (1706 and earlier) but PRs after this date are failing (1710 and later).

@marcosnils @HeartSaVioR

@marcosnils
Copy link
Contributor

@sazzad16 got it. Let's go ahead and merge this until we find a better fix.

@sazzad16 sazzad16 merged commit 3313195 into redis:master Dec 22, 2017
sazzad16 added a commit that referenced this pull request Dec 22, 2017
@sazzad16
Reduce sleep time to resolve test failing issue (#1718)
bdae9b3
@sazzad16
Copy link
Collaborator Author

Merged into master, 2.10.

@sazzad16 sazzad16 deleted the test-issue branch December 22, 2017 06:04
sazzad16 added a commit to sazzad16/jedis that referenced this pull request Jan 13, 2018
@sazzad16
Reset timeout to initial value
2b2aeb7 
This is apparently the most probable casue of issue that tempted the fix redis#1718.
@sazzad16 sazzad16 mentioned this pull request Jan 13, 2018
Merged
sazzad16 added a commit that referenced this pull request Dec 19, 2018
@sazzad16
Reset timeout to initial value (#1739)
3e348da 
This is apparently the most probable casue of issue that tempted the fix #1718.
joyang1 pushed a commit to joyang1/jedis that referenced this pull request Dec 27, 2018
@sazzad16
Reduce sleep time to resolve test failing issue (redis#1718)
1ccd6ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sazzad16 @marcosnils