Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify that pushing editor was successful (#658) #675

Merged
merged 1 commit into from
Dec 1, 2023
Merged

notify that pushing editor was successful (#658) #675

merged 1 commit into from
Dec 1, 2023

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Dec 1, 2023 •
edited
Loading

fixes #658

@adietish adietish self-assigned this Dec 1, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adietish adietish requested a review from datho7561 December 1, 2023 09:52
@adietish
Copy link
Collaborator Author

adietish commented Dec 1, 2023

@datho7561: I reintroduced the notification, that tells the user when pushing the editor to the cluster was successful. It wasn't clear to @maxandersen when he tried the editor if pushing had succeeded.
I had removed this notification when we thought that there were too many notifications. I'd love you to try it and tell me if we're back into "annoying" territory.

datho7561
datho7561 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'm good with this change.

I tried pushing a YAML that was missing some properties, so I spent a while reading the diagnostic, repushing, reading the new diagnostic... it was nice to finally see the "succeeded" message, and it made it consistent with all the other times I attempted to push.

@adietish
Copy link
Collaborator Author

adietish commented Dec 1, 2023

@datho7561 awesomeness, thanks a lot!

@adietish adietish merged commit 0942f18 into redhat-developer:main Dec 1, 2023
16 checks passed
@adietish adietish deleted the issue-658 branch December 1, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user I want to know that pushing the editor was successful
2 participants
@adietish @datho7561