Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support Multi Resource Files #549

Closed
berndwaibel opened this issue Dec 22, 2022 · 5 comments · Fixed by #551
Closed

Feature Request: Support Multi Resource Files #549

berndwaibel opened this issue Dec 22, 2022 · 5 comments · Fixed by #551

Comments

@berndwaibel
Copy link

I use yaml files, which contain more than one resource kind. All marked as invalid.
It seems there have to be only the same kind of resource per one file.
Feature Request: support Multi Resource Files

Example

apiVersion: v1
kind: Secret
metadata:
  name: jhipster-grafana-credentials
  namespace: default
data:
  username: xxxxxxx
  password: xxxxxxx
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: jhipster-grafana
  namespace: default
spec:
  replicas: 1
  selector:
    matchLabels:
      app: jhipster-grafana

Error Message:
Invalid kubernetes yaml/json

@adietish
Copy link
Collaborator

Hi @berndwaibel,
thanks for reporting this. We fully agree that we should support this. This is the next feature on our list and should be tackled in the next iteration.

@adietish
Copy link
Collaborator

adietish commented Jan 6, 2023

@berndwaibel:
We'll implement this in 2 steps:

  1. we'll allow to push all resources to the cluster. No pulling nor syncing will be possible. One can have a look at a diff though.
  2. we'll allow individual resources in your document to be pushed, pulled, diff'ed.
    How much in 2. do you consider useful for your tasks at hand?

adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 6, 2023
@berndwaibel
Copy link
Author

Thanks a lot.
I think it is a good plan to go through 1. and 2. step.

As you asked for my opinion:
The 2. step (sync/diff) is less important to me, as currently I could not use it at all, and to use it for pushing would be a very fast enhancement. During development process, a sync/diff would be nice, but not necessary. Delete/push would also work.

Maybe the sync/diff may be necessary on "prod" deployments, or on "preparing prod" deployments.
But then we may be outside the IDE (using ArgoCD or something).

@adietish
Copy link
Collaborator

adietish commented Jan 9, 2023

@berndwaibel thanks a lot for your feedback. As our goal is to provide what's useful to the user your feedback helps a lot.

adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 24, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 25, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 26, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 30, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Jan 31, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 2, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 2, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 2, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 3, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 3, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 3, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 3, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 6, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 7, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 8, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 9, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 10, 2023
adietish added a commit to adietish/intellij-kubernetes that referenced this issue Feb 10, 2023
@adietish
Copy link
Collaborator

adietish commented Feb 10, 2023

Hi @berndwaibel: this change is now in review (#551 (comment)). It took longer to complete due to other issues that had to be tackled first. And then, this is a rather big change and existing features need to still work as expected.
If everything works well this should get released to the marketplace very soon.

If you want to test it and provide feedback, ideas, bugs, I can easily give you a binary that you can manually install. Just tell me. 😃

adietish added a commit that referenced this issue Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants