Update nginx.conf to be compatible with nginx imagestreams on OCP 4.6 +

[fmenesesg]

What does this PR do?

Update nginx.conf to be compatible with latest nginx image stream (nginx:1.18-ubi8) and be able to use this app with pelorus examples

How should this be tested?

1. On an OCP 4.6 o later, create a new project

oc new-project nginx-test

2. Create the nginx app using images stream nginx:1.18-ubi8

oc new-app nginx:1.16-el8~https://github.com/fmenesesg/container-pipelines.git --context-dir=/basic-nginx

Is there a relevant Issue open for this?

resolves #160

Who would you like to review this?

cc: @redhat-cop/containers-approvers

[varodrig]

please assign @oybed

[garethahealy]

/assign @oybed

[varodrig]

QA raised an issue. Francisco will be reviewing.

[fmenesesg]

QA raised an issue. Francisco will be reviewing.

Fixed, I changed the image stream to nginx:1.16-el8 because nginx:1.18-ubi8 doesn't exist on OCP 4.6

[varodrig]

It's working now in OCP 4.6

[varodrig]

Can you please approve? thank you!
@etsauer
@garethahealy
@oybed
@pcarney8
@pabrahamsson
@sabre1041

[garethahealy]

have tried this on the opentlc shared cluster (https://console-openshift-console.apps.shared-na46.openshift.opentlc.com/), but that imagestream doesn't exist:

oc new-app nginx:1.18-ubi8~https://github.com/redhat-cop/container-pipelines.git --context-dir=/basic-nginx
error: multiple images or templates matched "nginx:1.18-ubi8"

The argument "nginx:1.18-ubi8" could apply to the following Docker images, OpenShift image streams, or templates:

* Image stream "nginx" (tag "1.14-el8") in project "openshift"
  Use --image-stream="openshift/nginx:1.14-el8" to specify this image or template

* Image stream "nginx" (tag "1.16-el7") in project "openshift"
  Use --image-stream="openshift/nginx:1.16-el7" to specify this image or template

* Image stream "nginx" (tag "1.16-el8") in project "openshift"
  Use --image-stream="openshift/nginx:1.16-el8" to specify this image or template

* Image stream "nginx" (tag "latest") in project "openshift"
  Use --image-stream="openshift/nginx:latest" to specify this image or template

[fmenesesg]

have tried this on the opentlc shared cluster (https://console-openshift-console.apps.shared-na46.openshift.opentlc.com/), but that imagestream doesn't exist:

oc new-app nginx:1.18-ubi8~https://github.com/redhat-cop/container-pipelines.git --context-dir=/basic-nginx
error: multiple images or templates matched "nginx:1.18-ubi8"

The argument "nginx:1.18-ubi8" could apply to the following Docker images, OpenShift image streams, or templates:

* Image stream "nginx" (tag "1.14-el8") in project "openshift"
  Use --image-stream="openshift/nginx:1.14-el8" to specify this image or template

* Image stream "nginx" (tag "1.16-el7") in project "openshift"
  Use --image-stream="openshift/nginx:1.16-el7" to specify this image or template

* Image stream "nginx" (tag "1.16-el8") in project "openshift"
  Use --image-stream="openshift/nginx:1.16-el8" to specify this image or template

* Image stream "nginx" (tag "latest") in project "openshift"
  Use --image-stream="openshift/nginx:latest" to specify this image or template

I forget to update the test instructions, now they are, please execute:

oc new-app nginx:1.16-el8~https://github.com/fmenesesg/container-pipelines.git --context-dir=/basic-nginx

[garethahealy]

/approve
/lgtm

[redhat-cop-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethahealy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [garethahealy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[varodrig]

thank you so much!