Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add listbans command #1316

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add listbans command #1316

wants to merge 3 commits into from

Conversation

Jigoku
Copy link
Member

@Jigoku Jigoku commented Dec 19, 2021

Allows server moderators to list active bans within the server in-game.

Changes proposed in this request:

  • /listbans
  • Restricts to G(banlock) privileges (but maybe this would be better as PRIV_ADMINISTRATOR ?)

I did intend to also add user tracking (added by: person) etc, although couldn't get ipinfo to store it properly right now. Whether that's something to add later.

2021-12-19-064527_1920x1080_scrot

@Jigoku
Copy link
Member Author

Jigoku commented Dec 19, 2021

Now outputs the name of the person who applied the ban;

1: [ban] 192.168.0.69 (reason: trolling [unixfreak])
2: [ban] 192.168.0.42 (reason: more trolling [unixfreak])

etc

@qreeves
Copy link
Member

qreeves commented Jan 17, 2022

  • I think it is unwise to include the name of the person from the client's side, as this could be edited out by a malicious user.
  • If a user is authed, it should probably include their authname.
  • If you're going to add a list command for one thing, it's probably a good idea to do it for all the addcontrol types.
  • When you change the network protocol, you need to bump GAMEVERSION in src/game/game.h.

@q009
Copy link
Member

q009 commented Jun 5, 2022

Any updates on this?

@qreeves qreeves self-assigned this Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants