Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript types and testing #40

Merged
merged 4 commits into from
Jan 14, 2019
Merged

Add typescript types and testing #40

merged 4 commits into from
Jan 14, 2019

Conversation

rosskevin
Copy link
Contributor

@rosskevin rosskevin commented Jan 4, 2019 •
edited
Loading

Supersedes #39
Closes #37

  • fixed type definitions
  • added tests
  • integrated into test for ci

Good to merge @TrySound

@rosskevin rosskevin mentioned this pull request Jan 4, 2019
Closed
@rosskevin rosskevin mentioned this pull request Jan 11, 2019
Closed
@TrySound TrySound merged commit a21b136 into realadvisor:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript definitions
2 participants
@rosskevin @TrySound