Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard error pages #326

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Add dashboard error pages #326

merged 2 commits into from
Apr 4, 2024

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Apr 4, 2024

This ports in the initial error pages from our website so that the dashboard
error pages look polished. This does not yet update the documentation error
pages, which I am considering the next batch of work afterwards.

Changes here:

  • Organizes dashboard errors into an isolated path. There will be a separate
    path for less branded error pages for Proxito.
  • Error pages are consolidated to all match styles. For now the styles are
    fairly minor, but I'd want to return to these later. Our error pages have
    always been goofball pages, and I appreciate that.
  • I used fallback error templates in case I missed anything, it wouldn't be hard
    to eventually drop the fallback templates if we want.
  • The 404 page has some slight additional logic to point to the login view for
    now, with ?next. This mostly satisfies my complaint about the 404 page being
    misleading for users.

@agjohnson agjohnson requested a review from a team as a code owner April 4, 2024 00:12
@agjohnson
Copy link
Contributor Author

400/4xx fallback
401
403
429
500
504

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯 This is ready to merge.

Note there are maybe two extra pages here we will eventually want templates:

  1. 410 Gone -- for Spam project
  2. 418 I'm a teapot -- for dummy URLs defined in El Proxito

@agjohnson
Copy link
Contributor Author

Great point, I'll add 410 here too, that's easy enough.

The dummy response from proxito will use a different set of proxito error templates, that one is on the list at #304

@agjohnson
Copy link
Contributor Author

image

There is a complimentary change I'll push up in readthedocs/readthedocs.org#11263 to support a dashboard-only 410 error page.

@agjohnson agjohnson merged commit cf79a44 into main Apr 4, 2024
4 checks passed
@agjohnson agjohnson deleted the agj/error-pages branch April 4, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages: add missing 4xx/5xx error pages from the website
2 participants