Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation to Installation index page #347

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

ninh-nd
Copy link
Contributor

@ninh-nd ninh-nd commented Apr 25, 2023

This is my translation on the Installation index page. As this is my first time contributing to this project (and OSS in general), I have a few questions:

  1. I'm still not certain about the translation of "sandbox" so I left it untouched. Any comment on this would be helpful.
  2. Do I need to translate the parts that are not markdowns? (For example, the 'In this chapter' text that is rendered by a .tsx)

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ltmylinh
Copy link
Collaborator

This is my translation on the Installation index page. As this is my first time contributing to this project (and OSS in general), I have a few questions:

  1. I'm still not certain about the translation of "sandbox" so I left it untouched. Any comment on this would be helpful.
  2. Do I need to translate the parts that are not markdowns? (For example, the 'In this chapter' text that is rendered by a .tsx)

Thanks @ninh-nd.

  1. IMO with "sandbox" we can translate it into ô bên dưới, and I usually add the English next to the translation in case the Vietnamese words can be confused or hard to understand. For example, in this case, I will make ô bên dưới (sandbox) for it.
  2. I think we can ignore the text in the component when we do translation for pages like this. And we can add a task to translate some texts in the components later. That's my thoughts. Someone might have a better idea.

@Ryan-LT
Copy link
Member

Ryan-LT commented Apr 26, 2023

Hi @ltmylinh and @ninh-nd,

  1. Let's keep the sandbox as it is since it's an actual platform to run code on the cloud.
  2. Component texts should be kept. For most UI texts, the label will turn into confusion if we translate them. (eg: Button -> Nút Ấn). Those texts should be familiar to software engineers in general. I think we are trying to explain the document to people only.

@ltmylinh
Copy link
Collaborator

Hi @ltmylinh and @ninh-nd,

  1. Let's keep the sandbox as it is since it's an actual platform to run code on the cloud.
  2. Component texts should be kept. For most UI texts, the label will turn into confusion if we translate them. (eg: Button -> Nút Ấn). Those texts should be familiar to software engineers in general. I think we are trying to explain the document to people only.
  1. The sandbox here is a word, not the codesandbox - the platform that is being used to embed the code into the website. Btw, I respect people's thoughts so feel free to leave it as whatever ya'll think it's appropriate for Vietnamese people to learn tho 😊

@Ryan-LT
Copy link
Member

Ryan-LT commented Apr 26, 2023

Yeah. Exactly, I would keep mentioning that with "sandbox" because it's a direct reference to the codesanbox itself. Mentioning it using some other terms would lead to confusion, I can't find any proper name for it too. Looking forward to hearing your point.

@Ryan-LT Ryan-LT merged commit ddd3c0a into reactjs:main Apr 27, 2023
@ninh-nd ninh-nd deleted the translate/installation branch April 28, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants