Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of the “Mixins Considered Harmful“ blog post #133

Merged
merged 5 commits into from
Mar 29, 2019

Conversation

tdd
Copy link
Collaborator

@tdd tdd commented Mar 28, 2019

Salut @JeremiePat, je review ta propre trad aujourd'hui ! Voici un autre pavé pour le plaisir de tes yeux… 😜

@tdd tdd added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 28, 2019
@tdd tdd self-assigned this Mar 28, 2019
@tdd tdd requested a review from JeremiePat March 28, 2019 13:45
@netlify
Copy link

netlify bot commented Mar 28, 2019

Deploy preview for fr-reactjs ready!

Built with commit d3bd5a9

https://deploy-preview-133--fr-reactjs.netlify.com

Copy link
Collaborator

@JeremiePat JeremiePat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut :) Bon juste quelque micro bricoles, histoire de dire ;)

content/blog/2016-07-13-mixins-considered-harmful.md Outdated Show resolved Hide resolved
content/blog/2016-07-13-mixins-considered-harmful.md Outdated Show resolved Hide resolved
content/blog/2016-07-13-mixins-considered-harmful.md Outdated Show resolved Hide resolved
content/blog/2016-07-13-mixins-considered-harmful.md Outdated Show resolved Hide resolved
content/blog/2016-07-13-mixins-considered-harmful.md Outdated Show resolved Hide resolved

Another group of mixins we discovered were helpers for providing and consuming [React context](/docs/context.html). Context is an experimental unstable feature, has [certain issues](https://github.com/facebook/react/issues/2517), and will likely change its API in the future. We don’t recommend using it unless you’re confident there is no other way of solving your problem.
Nous avons aussi remarqué une autre catégorie de mixins, qui étaient des utilitaires pour interagir avec le [Contexte React](/docs/context.html). Le Contexte est une fonctionnalité expérimentale instable qui a [quelques soucis](https://github.com/facebook/react/issues/2517), et nous changerons sans doute son API à l’avenir *(ce qu’ils ont fait avec React 16.3, NdT)*. Nous déconseillons de l’utiliser à moins que vous soyez certain·e qu’il représente la seule solution à votre problème.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce serait bien d'avoir un lien dans ta note. au choix vers https://fr.reactjs.org/docs/context.html ou vers https://fr.reactjs.org/blog/2018/03/29/react-v-16-3.html#official-context-api (le deuxième est sans doute plus pertinent dans le contexte, c'est la suggestion que je fait)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ben en même temps y'a un lien vers la nouvelle API dans le texte principal de la remarque, du coup j'ai évité.

content/blog/2016-07-13-mixins-considered-harmful.md Outdated Show resolved Hide resolved
@JeremiePat JeremiePat added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Mar 29, 2019
@tdd tdd merged commit 7227523 into master Mar 29, 2019
@tdd tdd deleted the blog/mixins-considered-harmful branch March 29, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants