Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐Translation podcasts #129

Merged
merged 3 commits into from
Apr 2, 2019
Merged

🌐Translation podcasts #129

merged 3 commits into from
Apr 2, 2019

Conversation

lbelavoir
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Mar 22, 2019

Deploy preview for fr-reactjs ready!

Built with commit 05a3c88

https://deploy-preview-129--fr-reactjs.netlify.com

Copy link
Collaborator

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello
ca me semble bon, juste deux majuscules qui à conserver dans le nom des boites / projet / site

content/community/podcasts.md Outdated Show resolved Hide resolved
content/community/podcasts.md Outdated Show resolved Hide resolved
@sheplu sheplu added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 26, 2019
@tdd
Copy link
Collaborator

tdd commented Apr 1, 2019

@lbelavoir du coup peux-tu m'ajouter un commit de recalage comme pour Course : titres VO préservés, demi-cadratins pour les séparateurs ? Ça me permettra de concentrer ma revue sur le fond 😉

@tdd tdd added Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Apr 1, 2019
@tdd
Copy link
Collaborator

tdd commented Apr 1, 2019

@lbelavoir heu à la réflexion remplace les tirets par des deux-points, comme @linsolas : c'est mieux pour le français. Je recalerai sur la page Cours en revue finale.

@tdd tdd added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Apr 2, 2019
@tdd tdd merged commit 2966c47 into reactjs:master Apr 2, 2019
@lbelavoir lbelavoir deleted the podcasts branch April 2, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants