Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborator identified Jupyter bug in latest release, causing docker build failure #3

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

simonkeng
Copy link
Contributor

Hi @greglandrum,

My collaborator from our original repository, @deric4, has found a bug in the latest Jupyter release causing our docker build to fail.

@deric4 fixed this issue in our repository, but now we would like to updated these changes in the primary rdkit_containers repo. Let me know if you have any questions or concerns @greglandrum.

Thanks!

PS. would it be possible to add @deric4 as a contributor to this repository?

simonkeng and others added 2 commits June 26, 2018 11:20
…I've created a repo with detailed installation instructions and up-to-date notes regarding Jupyter usage.
@greglandrum
Copy link
Member

@simonkeng : I just created @rdkit/rdkit_containers and invited you and @deric4 as members. That organization has write access to this repo.
We should agree on how we want to handle merging PRs

@deric4 deric4 merged commit ca364fb into rdkit:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants