[core] Use rotation log file for application logging #49544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
force-pushed
the
hjiang/stream-to-logging
branch
from
678f21a to
ef0728b
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/stream-to-logging
branch
from
ef0728b to
9436e61
Compare
jjyao
reviewed
Jan 2, 2025
| ) | ||
| configure_log_file(out_file, err_file) | ||
| sys.stdout = out_file |
There was a problem hiding this comment.
This won't work if user's actor/task calls c++ code and in c++ there is std::cout << "xxxx"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup for oversized logging file. It supports rotated logging file via overriding stdout and stderr with logging module.
I already tried the existing
StreamToLoggermodule here:ray/python/ray/serve/_private/logging_utils.py
Line 357 in c18686a