Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default of correct-dir=-1 actually corrects towards *last* dE #390

Closed
o-smirnov opened this issue Jul 9, 2020 · 3 comments
Closed

Default of correct-dir=-1 actually corrects towards *last* dE #390

o-smirnov opened this issue Jul 9, 2020 · 3 comments
Assignees
Labels

Comments

@o-smirnov
Copy link
Collaborator

The intention was for correct-dir=-1 to apply only the inverse DI terms when correcting the data. This is the default in the parset.

However it seems the code (interval_gain_machine) expects a None in this scenario, not -1.

-1, rather, causes the inverse of the last DD term to be applied. This is not what we want, generally.

@o-smirnov o-smirnov added the bug label Jul 9, 2020
@o-smirnov o-smirnov self-assigned this Jul 9, 2020
@o-smirnov o-smirnov changed the title Deafult of correct-dir=-1 actually corrects towards *last* dE Defult of correct-dir=-1 actually corrects towards *last* dE Jul 9, 2020
@o-smirnov o-smirnov changed the title Defult of correct-dir=-1 actually corrects towards *last* dE Default of correct-dir=-1 actually corrects towards *last* dE Jul 9, 2020
@o-smirnov
Copy link
Collaborator Author

Yeah @SpheMakh check if you had it set to -1 when peeling in the NGC4993 field... On the bright side you can have much better images. 👯

@SpheMakh
Copy link
Collaborator

SpheMakh commented Jul 9, 2020

At this point, I actually hope I did!

@SpheMakh
Copy link
Collaborator

SpheMakh commented Jul 9, 2020

But I don't have the logs anymore, I have to redo the reduction and hopefully, there'll be an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants