Let the entropy module be optional #4525
Open
+67
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/entropy-is-optional
branch
from
230fbbd to
7c0d596
Compare
randombit
force-pushed
the
jack/entropy-is-optional
branch
from
7c0d596 to
ccc4b27
Compare
reneme
requested changes
Jan 6, 2025
src/lib/rng/auto_rng/auto_rng.cpp
Outdated
Comment on lines
23
to
24
| class Entropy_Sources; | ||
|
|
There was a problem hiding this comment.
This relates to lines 68 to 72 where Entropy_Sources is actually used if Botan doesn't have the system rng enabled. Probably, this needs another ifdef.
There was a problem hiding this comment.
Wasn't even required at all - removed
There was a problem hiding this comment.
Did you push all changes here? If I configure without entropy and system_rng botan fails to build with:
src/lib/rng/auto_rng/auto_rng.cpp:68:22: error: incomplete type 'Botan::Entropy_Sources' named in nested name specifier
68 | AutoSeeded_RNG(Entropy_Sources::global_sources(), reseed_interval)
| ^~~~~~~~~~~~~~~~~
build/include/public/botan/rng.h:26:7: note: forward declaration of 'Botan::Entropy_Sources'
26 | class Entropy_Sources;
| ^
ccc4b27 to
aa9b79b
Compare
It was previously required by the rng module, but this isn't really necessary, especially for anyone who is just using the system RNG. (And/or NIST DRBGs seeded with the system RNG.)
reneme
requested changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously required by the rng module, but this isn't really necessary, especially for anyone who is just using the system RNG. (And/or NIST DRBGs seeded with the system RNG.)