Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade DnsJava #2963

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Downgrade DnsJava #2963

merged 1 commit into from
Nov 24, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Nov 24, 2024

DnsJava 3.x crashes on devices without java.nio.file.Paths, which
desugar doesn't help with. Until minSdk is 26-ish (Android O), we should
continue using the 2.x version.

DnsJava 3.x crashes on devices without java.nio.file.Paths, which
desugar doesn't help with. Until minSdk is 26-ish (Android O), we should
continue using the 2.x version.
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │             compressed             │            uncompressed            
          ├───────────┬───────────┬────────────┼───────────┬───────────┬────────────
 APK      │ old       │ new       │ diff       │ old       │ new       │ diff       
──────────┼───────────┼───────────┼────────────┼───────────┼───────────┼────────────
      dex │  24.2 MiB │  24.1 MiB │ -131.1 KiB │  74.9 MiB │  74.6 MiB │ -298.8 KiB 
     arsc │   2.7 MiB │   2.7 MiB │        0 B │   2.7 MiB │   2.7 MiB │        0 B 
 manifest │   5.8 KiB │   5.8 KiB │        0 B │    28 KiB │    28 KiB │        0 B 
      res │     2 MiB │     2 MiB │       +4 B │   2.2 MiB │   2.2 MiB │        0 B 
   native │  18.8 KiB │  18.8 KiB │        0 B │  36.5 KiB │  36.5 KiB │        0 B 
    asset │ 404.2 KiB │ 404.2 KiB │        0 B │ 678.6 KiB │ 678.6 KiB │        0 B 
    other │ 258.7 KiB │ 256.5 KiB │   -2.2 KiB │ 579.8 KiB │ 574.2 KiB │   -5.7 KiB 
──────────┼───────────┼───────────┼────────────┼───────────┼───────────┼────────────
    total │  29.6 MiB │  29.5 MiB │ -133.3 KiB │    81 MiB │  80.7 MiB │ -304.4 KiB 

Copy link

Removed Dependencies
org.slf4j:slf4j-api:1.7.36

Upgraded Dependencies
dnsjava:dnsjava:2.1.9, (changed from 3.6.2)

@ahmedre ahmedre added this pull request to the merge queue Nov 24, 2024
@ahmedre ahmedre removed this pull request from the merge queue due to a manual request Nov 24, 2024
@ahmedre ahmedre added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit 491d2f0 Nov 24, 2024
2 checks passed
@ahmedre ahmedre deleted the downgrade_dnsjava branch November 24, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant