Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't allow for duplicate operating systems #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lj3954
Copy link
Member

@lj3954 lj3954 commented Oct 18, 2024

Description

Garuda Linux was duplicated in the spawn_distros macro call in 8b525f4. Duplicate distros (either through the name or pretty name, a program could choose to display either) can cause undefined behaviour and must not be present in the final data. This PR removes the duplicate entry in the macro call, as well as creating a separate function to remove all operating systems with duplicate names.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant