new: usr: JUPY-567, SDK-394: Add SDK bindings for JupyterNotebookCommand #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgvr
commented
Feb 28, 2020
chattarajoy
requested changes
Mar 1, 2020
|
@tarungavara, once you are done with the changes please rebase your branch once with the latest |
chattarajoy
reviewed
Mar 1, 2020
chattarajoy
reviewed
Mar 1, 2020
Co-Authored-By: Joy Lal Chattaraj <[email protected]>
Co-Authored-By: Joy Lal Chattaraj <[email protected]>
chattarajoy
force-pushed
the
unreleased
branch
2 times, most recently
from
8a95947 to
caec9b1
Compare
Co-Authored-By: Joy Lal Chattaraj <[email protected]>
chattarajoy
approved these changes
Mar 3, 2020
chattarajoy
previously approved these changes
Mar 4, 2020
added 2 commits
March 4, 2020 12:41
tgvr
changed the title
chattarajoy
previously approved these changes
Mar 11, 2020
chattarajoy
previously approved these changes
Mar 12, 2020
|
changes LGTM, @tarungavara please let me know when the changes are tested and ready to be merged. |
|
Also, please check and fix any relevant styling issues here https://deepsource.io/gh/qubole/qds-sdk-py/run/548529df-5275-42be-9a57-15a7830b5c02/python/ |
added 2 commits
March 12, 2020 12:08
|
@chattarajoy This is now ready to merge. |
chattarajoy
approved these changes
Mar 12, 2020
chattarajoy
added a commit
that referenced
this pull request
Mar 18, 2020
…and (#304) * changes * changes * changes * add tests * fix tests * changes to make scheduler create from command line work * Remove non ASCII characters Co-Authored-By: Joy Lal Chattaraj <[email protected]> * Remove redundant parenthesis Co-Authored-By: Joy Lal Chattaraj <[email protected]> * Update qds_sdk/commands.py Co-Authored-By: Joy Lal Chattaraj <[email protected]> * changes * changes * add support for macros * add name option * add support for tags * add support for notify and timeout * update tests * add support for pool * update tests * add support for retry and retry_delay * update tests * add support for jupyter_notebook_id * update tests * replace notebook id with uuid * remove support for uuid * seperate validate json input method * fix style * some more style fixes * changes Co-authored-by: Gavara Tarun <[email protected]> Co-authored-by: Joy Lal Chattaraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review:
Usage:
qds.py --token <> --url <> jupyternotebookcmd run|submit --path <> --uuid <> --cluster-label <> --arguments ‘{“key1”:”val1”}’ --macros <> --name <> --tags <> --notify --timeout <> --retry <> --retry-delay <> --pool <>
Test Cases:
These cases have been verified using my QiB.
Also, currently creating schedules from commandline is broken. I've made a small change in scheduler.py that fixes this.
temp.json contains
{ "command_type": "JupyterNotebookCommand", "command": { "path": "Users/[email protected]/m.ipynb" }, "start_time": "2019-12-26T02:00Z", "end_time": "2020-07-01T02:00Z", "frequency": 1, "time_unit": "days", "label": "spark" }A schedule is created, verified in UI.