fix: clarify signed & unsigned for jump insts #119
+14
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content
fix the signed/unsigned comparisons in several jump instructions in the
execute_program
functionKey changes include:
unsigned_u64!
to convert immediate values to unsigned 64-bit integers (i can be simply written as inst.imm as u32 as u64, the macro is just for better readability, i can change it back to the simpler version if you wish)JEQ_IMM
,JGT_IMM
,JGE_IMM
,JLT_IMM
,JLE_IMM
,JNE_IMM
) to use the newunsigned_u64!
macro, ensuring correct handling of unsigned comparisons.reference