Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename resonator folder and add missing __init__.py file #1009

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PositroniumJS
Copy link
Contributor

What are the issues this pull addresses (issue numbers / links)?

None

Did you add tests to cover your changes (yes/no)?

No need

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

  • the folder resonator was not in the installed package because of a missing __init__.py file
  • rename this folder resonator resonators for coherence with the other folders of qlibrary
  • correct some typos

Details and comments

Renaming the folder is a (small) breaking change

Copy link
Collaborator

@zlatko-minev zlatko-minev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked this all runs and works without bugs

@PositroniumJS
Copy link
Contributor Author

PositroniumJS commented Jan 8, 2025

Have you checked this all runs and works without bugs

Now after installation the folder resonators is well installed and showing up in the GUI. If you want to import an element from it you have to change resonator by resonators in the previous imports:
from qiskit_metal.qlibrary.resonators... import ...

The other changes are just typos in comments or documentation, and useless numpy import in two qubits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants