[ROCm] remove HCC references #8070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename __HIP_PLATFORM_HCC__ to WITH_ROCM This symbol has had a long deprecation cycle and will finally be removed in ROCm 6.0. The WITH_ROCM preprocessor symbol was already defined by setup.py, so choosing to use it here instead to indicate the same thing.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8070
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 82d127d with merge base 3fb88b3 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
No ciflow labels are configured for this repo. |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Oct 30, 2023
This reverts commit a63f98a.
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
Reviewed By: vmoens Differential Revision: D50789090 fbshipit-source-id: 569878f95d9adc67f4d6f425cef0aa35bc4d4b4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename
__HIP_PLATFORM_HCC__toWITH_ROCM.This symbol has had a long deprecation cycle and will finally be removed in ROCm 6.0. The WITH_ROCM preprocessor symbol was already defined by setup.py, so choosing to use it here instead to indicate the same thing.
cc @jithunnair-amd