-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets tutorial improvements #994
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/994
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a573b14 with merge base bbf0010 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great tutorial updates. I've left some comments and questions, some of them just because this was my first time going through the tutorial. One concern I have with the way we're doing deepdives/tutorials is that we're putting a lot of important information here while our API references are pretty sparse. I'm afraid that people won't take the time to go through the tutorial and jump to what they're looking for in the api reference section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this and updating from all the comments.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
Sample packing will have a dedicated page, so details on that are limited for now.
Test plan
doc build, pytest tests