[Nova] Pass the smoke test scripts to Reusable Workflow #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiwangmeta
reviewed
Oct 31, 2022
build-conda-macos.yml is introduced in #1973 which is not merged yet. That PR already passes the smoke test script. |
Ah I missed that. Let me approve this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the smoke-test script is not passed to the reusable workflow, it will just use the naive smoke test implemented in the reusable workflow. Passing it (as we do here) will ensure the smoke test script that exists in this repo gets run after the build is complete.