Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RTE dataset with unit tests #1721

Merged
merged 8 commits into from
Jun 1, 2022
Merged

Add support for RTE dataset with unit tests #1721

merged 8 commits into from
Jun 1, 2022

Conversation

vcm2114
Copy link
Contributor

@vcm2114 vcm2114 commented May 12, 2022

Summary

  • Added support for RTE dataset
  • Added mocked unit tests for RTE dataset

Test

  • pytest test/datasets/test_rte.py

Context

See #1710

@vcm2114 vcm2114 mentioned this pull request May 12, 2022
Closed
8 tasks
@vcm2114 vcm2114 requested a review from Nayef211 May 18, 2022 20:05
Nayef211
Nayef211 approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torchtext/datasets/rte.py Outdated Show resolved Hide resolved
Nayef211
Nayef211 reviewed May 19, 2022
View reviewed changes
torchtext/datasets/rte.py Outdated Show resolved Hide resolved
parmeet
parmeet approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's address the comments before landing :)

@vcm2114 vcm2114 merged commit 932d776 into pytorch:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayef211 Nayef211 Nayef211 approved these changes

@parmeet parmeet parmeet approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vcm2114 @parmeet @Nayef211 @facebook-github-bot