Add support for QQP dataset with unit tests #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Nayef211
approved these changes
May 17, 2022
There was a problem hiding this comment.
LGTM. Can we also make sure to add the sharding filter to the dataset as @parmeet mentioned here #1710 (comment).
Btw I think we can land irrespective of the test failures coming from linux (since this is caused by some recent changes related to torchdata). As long as all the tests are passing on mac os.
Nayef211
reviewed
May 18, 2022
| file_name = "quora_duplicate_questions.tsv" | ||
| txt_file = os.path.join(base_dir, file_name) | ||
| mocked_data = [] | ||
| print(txt_file) |
There was a problem hiding this comment.
Can we remove the print statement here
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.root_dir = cls.get_base_temp_dir() | ||
| print(cls.root_dir) |
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test
pytest test/datasets/test_qqp.pyContext
See #1710