Fix 2.5.1 failing sparsity test #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1261
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 872bf90 with merge base 75f52ae ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
approved these changes
Nov 11, 2024
sunjiweiswift
pushed a commit
to sunjiweiswift/ao
that referenced
this pull request
Nov 25, 2024
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
* feat(tokenizer): Add an abstract base class for additional tokenizer support Branch: GraniteCodeSupport Signed-off-by: Gabe Goodhart <[email protected]> * feat(tokenizers): Add a python impl of the Tokenizer interface using tokenizers This allows for all HF tokenizers to be supported in the python layer. It will need significant work to offer similar compatibility at the c++ layer. Signed-off-by: Gabe Goodhart <[email protected]> * feat(builder): Add support for using the TokenizersTokenizer in builder Branch: GraniteCodeSupport Signed-off-by: Gabe Goodhart <[email protected]> * feat(tokenizers): Add and plumb the option to use the "tokenizers" tokenizer Branch: GraniteCodeSupport Signed-off-by: Gabe Goodhart <[email protected]> * fix(tokenizers): Fix how bos/eos tokens are parsed from tokenizers (lib) Branch: GraniteCodeSupport Signed-off-by: Gabe Goodhart <[email protected]> * fix(hf_tokenizer): Rename to HFTokenizer and corresponding flags pytorch/torchchat#1251 Branch: TokenizersTokenizer-1251 Co-Authored-By: [email protected] Signed-off-by: Gabe Goodhart <[email protected]> --------- Signed-off-by: Gabe Goodhart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
TORCH_VERSION_AFTER_2_5but I really wantedTORCH_VERSION_AT_LEAST_2_6, which won't run with torch==2.5.1